Integrate June 9 Nightly RN Build#8147
Merged
10 commits merged intoJul 15, 2021
Merged
Conversation
Commits: facebook/react-native@0d32aef...386dbd9 Has ACoates fixes for RNTester theming, and testID in NewAppScreen header. Will manuallly validate that the new RNTester example in facebook/react-native@7463f6d works as expected on UWP. It does not run on NetUI due to using instance-global dimension APIs.
Contributor
Author
|
Seeing fabric compile errors because someone added "#import" to C++ code again. Must be some Objective C devs leaking over 😛. Need to fork to #include and fix upstream... |
Contributor
Author
|
Snapshots also failing bc padding changed. Need to update those. |
Contributor
Author
|
Upstream PR to replace #import with #include: facebook/react-native#31805 Forked in the meantime |
Contributor
Author
|
Babel transformation of one of our e2e-test-app source files now fails for some reason. Going to try reverting |
acoates-ms
approved these changes
Jul 8, 2021
NickGerleman
added
the
AutoMerge
|
Hello @NickGerleman! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits: facebook/react-native@0d32aef...386dbd9
Has ACoates fixes for RNTester theming, and testID in NewAppScreen header.
Will manuallly validate that the new RNTester example in facebook/react-native@7463f6d works as expected on UWP. It does not run on NetUI due to using instance-global dimension APIs.
Microsoft Reviewers: Open in CodeFlow